jesseweed / seti-ui

A subtle dark colored UI theme for Atom.
MIT License
942 stars 285 forks source link

Add a .h header file icon instead of using the C icon #522

Open sean-mcmanus opened 5 years ago

sean-mcmanus commented 5 years ago

Actual: For .h files, the seti-ui theme is using the C icons. This is incorrect/misleading when .h files actually represent C++ files, which is commonly the case.

image

Expected: For .h files, a "H" header file icon should be used that is valid for C or C++. This would match the behavior of Visual Studio.

image

An alternative would be to have a C++ specific header for .hpp files, which is what the vscode-icons extension does, but I don't think that is necessary.

image

sean-mcmanus commented 5 years ago

The Studio Icons extension also handles this well (the icon looks like VS).

orta commented 5 years ago

Great idea, PRs welcome for this!