search

jesseweed / seti-ui

A subtle dark colored UI theme for Atom.
MIT License
942 stars 285 forks source link

Replace the java file icon with the old java cup icon #538

Closed sanket-bhalerao closed 2 years ago

sanket-bhalerao commented 5 years ago

Issue Type: Feature Request

change java icon to the java cup icon.

VS Code version: Code - Insiders 1.37.0-insider (0bd57ac9efae79f9eb1aedc3818ebbb570b9bf6b, 2019-08-02T21:22:13.578Z) OS version: Windows_NT x64 10.0.17134

java icon

a-stewart commented 2 years ago

Hi, this is a common question I have heard from a number of VS Code users, as the J icon (when small) looks like a red clock, which, anecdotally, is often confused with an error.

In the original PR that changed to this icon (https://github.com/jesseweed/seti-ui/pull/527), a second proposal was given which uses a less complicated cup.

https://user-images.githubusercontent.com/1369240/53309009-1ca07280-385a-11e9-9928-ce3812610510.png

Is this something that we could perhaps consider for Java files?

orta commented 2 years ago

I'm pretty open to it - @nickzhums (I just grabbed you as someone who will know folks using Java in vs code) do you have an opinions on the default java file icon?

nickzhums commented 2 years ago

thanks for including me on this one. Let me also mention our engineering team here : @eskibear @CsCherrYY @jdneo @testforstephen @akaroml

akaroml commented 2 years ago

+1 to use the coffee cup. The current one is easily confused with an error indicator.

nickzhums commented 2 years ago

@orta We have discussed internally and decided we should go ahead with the icon replacement. How should we go about this?

orta commented 2 years ago

Someone should send a PR 👍🏻

nickzhums commented 2 years ago

@eskibear

Eskibear commented 2 years ago

So shall we use the cup above? It would look like below:

image

And do we want to change the color? E.g blue, which is also part of Java icon's color, effect below:

image

nickzhums commented 2 years ago

tbh, blue seems a bit weird here - @orta do you have any suggestions? I'm ok with the red one (first picture)

sanket-bhalerao commented 2 years ago

could it be something like this? image

orta commented 2 years ago

No suggestions on color, I don't use Java so I don't know what colour is culturally close.

@sanket-bhalerao - that's probably going to look out of placed and unbalanced compared to the other icons which are visually centered 👍🏻

nickzhums commented 2 years ago

@orta for the icon, do we need a 16x16 or 20x20 ?

orta commented 2 years ago

Recommendations are in the README: https://github.com/jesseweed/seti-ui#adding-file-icons and then compare with others for feel

Eskibear commented 2 years ago

We had a survey on Twitter: https://twitter.com/NickZhu9/status/1517053859025195008 . Turns out users are more fond of a simple J icon. So I just created a PR for it. Below is the comparison with current behavior.

image