search

jesseweed / seti-ui

A subtle dark colored UI theme for Atom.
MIT License
941 stars 283 forks source link

use Go brand logo for .go files #568

Closed hyangah closed 4 years ago

hyangah commented 4 years ago

The only change I manually made is to replace icon/go2.svg with a new svg file. Changes to all other files were automatically done by gulp icon.

Before: Screen Shot 2020-05-22 at 7 46 01 PM

After: Screen Shot 2020-05-22 at 7 36 54 PM

Light color mode: Screen Shot 2020-05-22 at 7 36 05 PM

Note: gulp svg and gulp icon resulted in minimizing the existing babel.svg and prolog.svg. That is not what this PR intended, but I don't know how to avoid affecting these files.

Note: From the screenshot, I noticed the vs code now uses xml.svg for go.mod files and I don't know what caused this change.

Fixes #499 Fixes microsoft/vscode-go#1982

orta commented 4 years ago

Interesting, I'm unsure about the .mod file - I don't see anything in the template for it, maybe a change on vscode side between versions?

https://github.com/jesseweed/seti-ui/blob/master/styles/components/icons/mapping.less

hyangah commented 4 years ago

Thanks @orta. I confirm the change of .mod file icon isn't caused by this PR.

From the dev instance built from vscode head, I see go.mod still uses the xml language icon. image

I don't know what caused vscode to believe go.mod to be a xml file. If it happens in the released version of vscode, we need to report this to vscode.