search

jesseweed / seti-ui

A subtle dark colored UI theme for Atom.
MIT License
941 stars 283 forks source link

.tsx icon fix #576

Closed coolansplanet closed 3 years ago

coolansplanet commented 3 years ago

.tsx files are currently associated to "typescript", so it is displaying the regular "ts" icon instead of the React one. This is a fix to it

orta commented 3 years ago

This recently changed, and I think I'm OK with keeping it as it is 👍🏾

Thanks for the PR though!

coolansplanet commented 3 years ago

No worries!

ilyapopovs commented 2 years ago

Hi @orta 👋

Has the opinion on this matter changed since the PR was closed? 🤔

I see that the initial change was initiated by this discussion https://github.com/jesseweed/seti-ui/issues/557, but it wasn't highly upvoted, and was based around a rather unpopular use-case in the industry. I understand that React is not the only framework/library that uses JSX, and yet .jsx files do have the React component icon. Here's a good stackoverflow question on ts vs tsx

orta commented 2 years ago

Nope, my opinion's not really changed 👍🏻

ilyapopovs commented 2 years ago

Ok 👌

Thank you for your work on the project though! 🙂