search

jesseweed / seti-ui

A subtle dark colored UI theme for Atom.
MIT License
941 stars 283 forks source link

Extend Ruby icon support for Gemfile formats #585

Closed MichaelCurrin closed 3 years ago

MichaelCurrin commented 3 years ago

Hi, I am VS Code user using the vs-seti theme.

I noticed that the Gemfile file doesn't have a Ruby icon and so I added one by updating the mapping file. I based changes on the Makefile pattern at the end of the file (using .icon-partial to match on filename and adding two rows to handle the case).

VS Code already recognizes a bunch of files like .rbx, .gemspec and Rakefile as Ruby and gives them the correct icon, so I didn't change those.

Thanks

MichaelCurrin commented 3 years ago

Current behavior

rb1

Note Gemfile is recognized type Gemfile and not type Ruby in the Language settings.

Expected behavior

rb2

I temporarily changed the file to type Ruby for the icon to appear.

orta commented 3 years ago

👍🏻 Yeah, this is good

MichaelCurrin commented 3 years ago

Awesome, thanks :)

MichaelCurrin commented 3 years ago

FYI I just create an issue on VS Code repo to get this update pulled in - https://github.com/microsoft/vscode/issues/108185