search

jesseweed / seti-ui

A subtle dark colored UI theme for Atom.
MIT License
941 stars 283 forks source link

Add MCFUNCTION icon #637

Closed joker876 closed 2 years ago

joker876 commented 2 years ago

.mcfunction is a popular file extension used by Minecraft's datapack function system.

Files of this type are used very often, and a lot of people use VS Code to edit them. There are projects involving .mcfunction files that reach millions of downloads, which in my opinion warrants adding this icon.

Here is the wiki page explaining what those files are: https://minecraft.fandom.com/wiki/Function_(Java_Edition)

joker876 commented 2 years ago

I should also add that the most popular VS Code extension adding language support for .mcfunction has ~53k downloads.

orta commented 2 years ago

Looking at that preview (its not square for example), it's hard to tell if that filetype is going to look good with the rest of the iconset - have you seens what it looks like in vscode?

Screenshot from 2022-03-03 09 43 11

joker876 commented 2 years ago

I actually stumbled upon a VSCode extension that has a very good icon, which I think would fit here very well. I will ask the owner for permission to use it.

joker876 commented 2 years ago

Permission granted, I will re-create that icon as an svg and post a new PR later this day