jesseweed / seti-ui

A subtle dark colored UI theme for Atom.
MIT License
941 stars 283 forks source link

Add more extensions to documentation files #642

Closed Semphriss closed 2 years ago

Semphriss commented 2 years ago

This is a transfer from microsoft/vscode#144144. For convenience, I copied the issue and PR descriptions in here.


Certain files, like CHANGELOG, CONTRIBUTING, TODO etc. have special icons. However, if they are suffixed with .md or .txt, they sometimes no longer have their icons.

I would like that such special files also have those icons when they have extensions in their names; many OSes support linking a program to open files with certain extensions (e. g. a markdown reader for .md, or a text editor for .txt). Although VSCode does not have this problem, many of my users use the regular Notepad to read those files; for their convenience, I need to append all my documentation files with .txt (or .md) so that they can easily open those files in their preferred program.

For convenience, here are the pairings that have special icons:

File name .md .txt (no extension)
Readme x
Changelog x x
Changes x
Version x x
Licen[cs]e x x
Copying x
Compiling x
Contributing x
Todo x

I would like to propose to make it so all pairings have the special icon corresponding to the file name.

I added every combination; if certain pairings are accepted but others rejected, I am open to remove them. I also left "Allow edits by maintainers" checked, so edits can be pushed directly to this PR if necessary.

I believe .txt and .md are the only two extensions commonly used for this type of files, but if other extensions are known, I'm open to add them in this PR.

orta commented 2 years ago

I think this is reasonable - I used GitHub search to check out the majority of these files which ranges from 9.4M README.txt to 25k CONTRIBUTING.txt and I think the consistency is enough to allow some of the smaller ones. Thanks.

HaveSpacesuit commented 2 years ago

Y'all are too clever. I noticed my trusty todo.txt file has its icon updated after updating VS Code today. đź‘Ť

image