search

jesseweed / seti-ui

A subtle dark colored UI theme for Atom.
MIT License
941 stars 283 forks source link

Regenerate font to add missing icons and codepoints #650

Closed provokateurin closed 2 years ago

provokateurin commented 2 years ago

I noticed there were a bunch of missing codepoints in the seti.less file, so I just ran gulp icons which fixed everything. (For some reason the icons were also updated, but that was also automatically.)

provokateurin commented 2 years ago

Maybe it's good to add a pipeline that fails when the fonts and icons are not up-to-date to prevent this from happening again?

orta commented 2 years ago

We ask people not to do it in the README/contributing guides so that it doesn't cause conflicts on PRs, the build pipeline is ran in the when moving icons into vs code which is fine by me 👍🏻

That said, I'm cool with merging this because why not have it up to date

provokateurin commented 2 years ago

Thanks :) I'm using the icons and font in a different project and the missing code points were causing problems, so it's nice to have the up-to-date.