jesseweed / seti-ui

A subtle dark colored UI theme for Atom.
MIT License
941 stars 283 forks source link

Some glyphs broken in font file #663

Open Finii opened 1 year ago

Finii commented 1 year ago

While the svgs render ok, some of them have issues when used in a ttf or other open type font.

Have a look at the marked glyphs / icons. They all should have some 'holes' in the glyph, but it is missing. (Well, the react has a black dot in the middle that is missing.)

image

Obvious problems in code-search go puppet react reasonml zip

Some more glyphs have less obvious problems and/or multiple layers, that could lead to problems when the font is used on Windows. Probably the svgs should be hand-simplified down to being only one path (and not multiple paths, let alone on multiple layers), before importing into the font.

(Came up with https://github.com/ryanoasis/nerd-fonts/commit/f2c365f4697774a14f4bab26f953a471e71c3995 and around that, while updating the Seti icons in Nerd Font)

Finii commented 1 year ago

Counterexample, same icons 'fixed':

image