jesseweed / seti-ui

A subtle dark colored UI theme for Atom.
MIT License
941 stars 283 forks source link

Enhance JS/JSX and TS/TSX #693

Open birkskyum opened 3 months ago

birkskyum commented 3 months ago

While React did pioneer a JSX/TSX syntax a decade ago, there is an increasing number of libraries other than react that rely on JSX/TSX. Notable examples are SolidJS, Vue and Preact which can use the .tsx/.jsx extensions, or in the case of vue have a .vue allowing it to have a dedicated icon.

To account for this diverse ecosystem, this PR therefore remove an obsolete assumption that "jsx = react" and changes the jsx/tsx to a jsx/tsx icons accordingly. This also making jsx<->tsx migration a bit easier, while keeping the spec / test colors as they are, in accordance with https://github.com/jesseweed/seti-ui/pull/611.

@orta , what do you think of this change?

Before

Screenshot 2024-03-18 at 22 06 25

After

Screenshot 2024-03-18 at 22 18 35