search

jessezach / RobotEyes

Image comparison for Robot Framework
MIT License
75 stars 24 forks source link

Update to use of SeleniumLibrary #6

Closed s-galante closed 6 years ago

s-galante commented 6 years ago

Any chance there will be an update to the base to include the shift from Selenium2Library to SeleniumLibrary as Selenium2Library will be considered deprecated in the latest version per: http://robotframework.org/Selenium2Library/Selenium2Library.html

I currently use a modded init file to target the SeleniumLibrary to limit the need to install the older library on my docker calls for basic image testing. Currently it looks like it may only effect the a few calls and as of now the direct change to the call in open_eyes works as is without mods to the other code.

jessezach commented 6 years ago

@s-galante I think we should do the update. Supporting SeleniumLibrary as well as the Selenium2Library for now makes sense imo. Would you like to raise a PR for this?

jessezach commented 6 years ago

@s-galante I got some time to work on this today. Here is the pull request. https://github.com/jz-jess/RobotEyes/pull/7 It worked fine during testing. Let me know if there are any more changes required. Also, I'm removing the support for appium since I never really got the chance to test it out.

s-galante commented 6 years ago

Same selenium change I was using as well. No issues with the change and no issues found with the Appium removal. Thanks for getting to this so quickly.

jessezach commented 6 years ago

Pull request has been merged. Support for SeleniumLibrary in version 0.56. pip install robotframework-eyes==0.56. Closing this. Thanks @s-galante

DiegoSanchezE commented 5 years ago

Hi Jess, did this improvement get carried into v0.58 or am I missing something? Thanks!

jessezach commented 5 years ago

@DiegoSanchezE Just pass SeleniumLibrary as an argument to the open eyes keyword. open eyes lib=SeleniumLibrary

Since a few other users wanted it to still support AppiumLibrary, the code has been made a little flexible to let users pass the name of the library they want to instantiate

DiegoSanchezE commented 5 years ago

Sweet! Thanks!