search

jessezach / RobotEyes

Image comparison for Robot Framework
MIT License
75 stars 24 forks source link

Adding support for seleniumlibrary #7

Closed jessezach closed 6 years ago

idxn commented 6 years ago

If this pull got merge, could we still use Roboteye with the appiumlibrary?

jessezach commented 6 years ago

@idxn Im afraid not. Although the keyword has not been removed, open eyes keyword would no longer get current Appium instance. Have you tried using RobotEyes with AppiumLibrary? I can add the support back if it is something that is still of any use. Maybe passing the library name as an argument to the open eyes keyword would then support Appium and Selenium and also avoid basic code changes in case of name changes. Thoughts?

idxn commented 6 years ago

@jz-jess I have planned to use with appium and haven't tried it yet. I looked into the issues and found this. I agree that passing the lib name is a better way to go.

jessezach commented 6 years ago

@idxn I have updated the code to include an optional "lib" argument which is None by default. By default, calling open eyes will get instance of Selenium2Library or SeleniumLibrary unless another library name is passed from robot test as an argument.