search

jessfraz / dockfmt

Dockerfile format and parser. Like `gofmt` but for Dockerfiles.
MIT License
427 stars 20 forks source link

dockfmt fmt duplicates lines in Dockerfile #3

Closed ullbergm closed 6 years ago

ullbergm commented 6 years ago

When I run dockfmt against the dockerfile that is included in the project it is like it appends to the file every time it processes a line, resulting in a huge file with tons of duplicated lines.

Resulting Dockerfile

[centos@centos-developer test]$ cp Dockerfile Dockerfile.orig
[centos@centos-developer test]$ ./dockfmt-linux-amd64 fmt -w Dockerfile
[centos@centos-developer test]$ ls -la
total 16
drwxrwxr-x   2 centos centos   47 Jun 12 10:54 .
drwx------. 31 centos centos 4096 Jun 12 10:53 ..
-rw-rw-r--   1 centos centos 4205 Jun 12 10:54 Dockerfile
-rw-rw-r--   1 centos centos  659 Jun 12 10:54 Dockerfile.orig
[centos@centos-developer test]$ ../dockfmt-linux-amd64 --version
dockfmt version v0.3.0
[centos@centos-developer test]$ cat /etc/redhat-release
CentOS Linux release 7.5.1804 (Core)
[centos@centos-developer test]$
jessfraz commented 6 years ago

Ah yeah this isn't really ready for prime time, thanks for trying it :) patches welcome