Project Feedback

[jessicalam]

@stuartpearman Can you take a look at this? It's hosted here and meets the following criteria:

• [x] Includes a button that when clicked, will toggle the website between day and night themes
• [x] When a user changes the theme, their choice is remembered in localStorage
• [x] The class on the body element is always up-to-date with the current theme (either day-theme or night-theme) -- you can use document.body.setAttribute('class', 'some-class-name') to set the class on the body
• [x] When the body has the class day-theme, the background of the website is light-colored, with a darker color for the text
• [x] When the body has the class night-theme, the background of the website is a very dark color, with a lighter color for the text
• [x] Somewhere on the page, the user is told how many times they've visited the website (starting with 1 the first time)

is the page supposed to refresh every time the button is pushed? I didn't do that.

[stuartpearman]

I love the //FOR THE COUNTER ELEMENT comment, I encourage you to comment all your code like this (though you don't have to) 🙂

The only thing I would change is that on the first load of the page, you need to press the "Day / night mode" button twice before it changes to night mode. You can fix this by checking if window.localStorage.getItem('storage') returns anything and setting storage to 'day-mode' if not.

You can use an if statement to do this, or the || operator.

Let me know if you need a hint!

[jessicalam]

maybe this is fixed.... ? It seems like it is.

[jessicalam]

hi I think this is fixed. :)

[stuartpearman]

Hey Jessica, I think your code review got lost during the site outage, sorry about that, thanks for commenting again!

It seems not to be updated on the https://lamjess1-kapstpq2uw6ovwmudce.surge.sh/ link, did you run the surge command again? You can type this into your terminal:

surge . --domain lamjess1-kapstpq2uw6ovwmudce.surge.sh

[jessicalam]

I changed it! :)

[stuartpearman]

Hi Jessica, it seems to be broken 🙁

The culprit is this line here:

var storageTheme = window.localStorage.getItem('storage') || 'day-mode'

Everywhere else in your code, you're setting the 'theme' item in localStorage, here though you're setting 'storage'

Let me know if you have any questions

[jessicalam]

hopefully maybe this is okay now. :)

[jessicalam]

wait it says it was unable to publish. I'll ask you about this Tuesday

[jessicalam]

https://jessicalam.github.io/MI-449-SS17-740-js-localstorage-wMUDce/ Here is the link to the page because surge isn't working

[stuartpearman]

Looks good Jessica! :shipit: