jest-community / eslint-plugin-jest

ESLint plugin for Jest

MIT License

1.13k stars 230 forks source link

feat: remove `no-if` rule #1528

Closed G-Rath closed 6 months ago

G-Rath commented 6 months ago

BREAKING CHANGE

SimenB commented 6 months ago

(not against it, but why? missing motivation/issue I think 😅 )

G-Rath commented 6 months ago

Do you mean for the changelog or that you've forgotten the history? (I don't blame you if so😅)

We replaced it with no-conditional-in-test which does the same but with more conditions, but we kept forgetting to actually remove this rule in our follow-up majors...

1049 & #1027

SimenB commented 6 months ago

haha, both! 😅 The BREAKING CHANGE part of the commit message should include motivation/migration path.

G-Rath commented 6 months ago

🤦 it's been so long I forgot that

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 28.0.0-next.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 28.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: