search

jest-community / eslint-plugin-jest

ESLint plugin for Jest
MIT License
1.12k stars 229 forks source link

fix(no-large-snapshots): avoid `instanceof RegExp` check for ESLint v9 compatibility #1542

Closed G-Rath closed 3 months ago

G-Rath commented 3 months ago

Cherry picked from https://github.com/jest-community/eslint-plugin-jest/pull/1534 - it seems that globals are different in ESLint v9 resulting in the same issue with instanceof that Jest has (https://github.com/jestjs/jest/issues/2549); it should be fine to switch the check to checking for a string (in fact it's arguably better as it means people could provide their own custom object with a test function 🤷)

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 28.0.0-next.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 28.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: