search

jest-community / jest-editor-support

A module for handling editor to jest integration
MIT License
28 stars 21 forks source link

Typescript-lite - minimal conversion to Typescript #33

Closed rossknudsen closed 4 years ago

rossknudsen commented 4 years ago

This is another attempt at converting to TS. This time, a minimal approach was taken since the previous attempt was too large to review. Since Babel can translate JS with Flow as well as Typescript, this works well (pretty sure the TS compiler doesn't understand Flow). So the changes are mostly to configuration files with a single example JS file converted to TS as a proof of concept (/src/index.js => /src/index.ts).

Inclusion of a .gitattributes file and changing single quotes to double quotes in the package.json scripts was introduced to help with Windows compatibility.

rossknudsen commented 4 years ago

Hey all. Just wanted to check if there was anything missing from this PR? I'm happy with it and as far as I can tell, I've either updated the code in response to comments or provided justification for the current changes. But I'm not sure what the etiquette is and this is my first contribution to OSS that has peer review.

Not being pushy, just wanting to check that I'm not holding things up 😃

connectdotz commented 4 years ago

Just wanted to check if there was anything missing from this PR?

@rossknudsen thanks for being patient, I checked the latest change and tested with vscode-jest, it all seemed fine! 👍 I think this PR will kickoff the ts migration that we all wanted for a while 😄

I will merge it later today.