fix snapshot, runner, test_reconciler

jest-community / jest-editor-support

A module for handling editor to jest integration

MIT License

28 stars 21 forks source link

fix snapshot, runner, test_reconciler #63

Closed connectdotz closed 3 years ago

connectdotz commented 3 years ago

change summary

typescript types

fix typescript types for coverage

Runner

adding extra arguments for more granular control of the run process
allow passing node_env
emit close and exit events separately

test_reconciler

add API to remove file from cache

snapshot

fixes snapshot parsing for flow and typescript files
refactor and clean up parser modules and tests
upgrade "jest-snapshot" dependency

stephtr commented 3 years ago

I'm really sorry, but currently I have hardly any spare time available for this project. Unfortunately, I also don't know when I'll have time to comment on the other PRs.

So far this PR looks good to me.

connectdotz commented 3 years ago

@stephtr no need to be sorry, we all do what we can, I appreciate you are taking the time to review this. Personally, I found review adds tremendous value by simply providing a different perspective, but I also understand that it is a mental overhead for the reviewers. A review is indeed a gift that I think should never be taken for granted. Thanks!