search

jest-community / jest-snapshots-svg

Take a React component tree, and render it into an SVG.
MIT License
220 stars 26 forks source link

What's the end goal? #24

Open JReinhold opened 7 years ago

JReinhold commented 7 years ago

Just wondering, how do you want the SVG results to be, when this repo hits 1.0? does it serves the purpose of rendering a complete 1:1 representation of the view, or is it instead to get an overview of the layout of the views and children?

I'm asking because if you are seeking a 1:1 representation it would relevant to add support for stuff like borderRadius and shadows. But if we instead want a visual overview of the hierarchy, then rendering boxes with borders is more informative, and shadows etc. might be less useful.

I'm also asking because I'm thinking of contributing. :)

orta commented 7 years ago

I'm a bit less interested in exact representation - but much more interested in overall shape and flow. I'd like to be able to reasonably see that a layout looks different on iPad/iPhone and watch how things can re-flow when features change

See this issue for my original vision: https://github.com/artsy/emission/issues/442

I'll add a vision file to this repo now

orta commented 7 years ago

Added 👍

JReinhold commented 7 years ago

Arh okay, that makes sense.