search

jest-community / jest-snapshots-svg

Take a React component tree, and render it into an SVG.
MIT License
221 stars 23 forks source link

Use yoga-dom instead of yoga as a dependency for handling layouts #50

Open orta opened 6 years ago

orta commented 6 years ago

@vincentriemer do you consider yoga-dom "production-ready" ish?

Right now we're using the gyp yoga, and it's a pain, and basically blocks the project being used in any Artsy app.

https://github.com/vincentriemer/yoga-dom

orta commented 6 years ago

Took a WIP stab with https://github.com/jest-community/jest-snapshots-svg/pull/52

vincentriemer commented 6 years ago

I think I’d answer that as “I’m not sure”. It really hasn’t had much testing done against it besides react-native-dom but it’s also mainly the original yoga source with a thin binding layer so there isn’t as much of a surface area for bugs.

I do need to add some docs at some point because the API is different but I’m currently swamped with all things related to the RNDom release. As a starting point the flow type definitions within RNDom should be useful: https://github.com/vincentriemer/react-native-dom/blob/master/packages/react-native-dom/flow-typed/npm/yoga-dom.js

Sent with GitHawk