search

jest-community / vscode-jest

The optimal flow for Jest based testing in VS Code
MIT License
2.83k stars 291 forks source link

Backticks in test case description cause the debugging and monitoring to fail #247

Open daelmaak opened 6 years ago

daelmaak commented 6 years ago

Environment

  1. node -v: 9.2.0

  2. npm -v: 5.5.1

  3. npm ls react-scripts (if you haven’t ejected): empty

  4. Operating system: [fill] Win 10

Steps to Reproduce

1) Have a passing test with single quotes in description 2) Then changing single quotes to backticks 2018-02-03_21h19_33

Expected Behavior

The status on the left side of the test case is green, debugging works and error messages are provided next to code in case the test is not passing.

Actual Behavior

The status shows the test as not being run although it runs in the background. If not passing, there are no error messages next to code, only red underline on the culprit row. Debugging doesn't work in this test case.

seanpoulter commented 6 years ago

Thanks for reporting the issue @daelmaak.

That's a issue with jest-editor-support. There's an open issue for it that just needs some attention and a PR. Have a look at facebook/jest#4910.

daelmaak commented 6 years ago

I see you already started with the PR @seanpoulter, are you still working on that?

seanpoulter commented 6 years ago

Nope. I stopped with that last comment. If I was going to jump back into it, I'd want to go have a look how the AST handles tagged template literals:

tag `string text ${expression} string text`
jkjustjoshing commented 5 years ago

Looks like this comment indicates that this might just need some version/dependency shuffling to get this working?

connectdotz commented 5 years ago

hi, template-literal-string support has been added to 3.0.0-preRelease, feel free to give it a try...