jesterKing / import_3dm

Blender importer script for Rhinoceros 3D files

MIT License

308 stars 38 forks source link

Read3dm settings #46

Closed tsvilans closed 5 years ago

tsvilans commented 5 years ago

Update read_3dm() to take options dict

The function arguments are growing in count. Anticipating this as well as more import options, this updates read_3dm() to take a dict instead which contains all import options.

detailed explanation

Creates dict in Import3dm.execute() and passes it to read_3dm()
Parses options dict in read_3dm() and assigns default values if keys are not found.

fixes / resolves

Fixes an expanding argument list for read_3dm(), improving legibility.

tsvilans commented 5 years ago

@lfertig I'd like to coordinate this with you, as it would break your 2 PRs... If this looks OK, we can merge it and then it could be integrated in your 2 open PRs?

lfertig commented 5 years ago

I was already wondering about this, and your solution looks nice and clean. Definitely easier to extend features.. go ahead and merge it! I'll fetch the changes and adapt my code accordingly.