search

jestjs / jest

Delightful JavaScript Testing.
https://jestjs.io
MIT License
44.12k stars 6.44k forks source link

fix type of `testFailureExitCode` config option #15232

Closed k-rajat19 closed 1 month ago

k-rajat19 commented 1 month ago

Summary

According to types testFailureExitCode can also take string values.

Test plan

Green CI

netlify[bot] commented 1 month ago

Deploy Preview for jestjs ready!

Name Link
Latest commit b2f9112e92ba399d9d8ea89a70fa87d3c8de82c0
Latest deploy log https://app.netlify.com/sites/jestjs/deploys/66b8a8ef3903ee0008e6c3b0
Deploy Preview https://deploy-preview-15232--jestjs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

SimenB commented 1 month ago

That's just because all CLI arguments are strings. But we probably don't need to say that in the types, so real fix is probably to remove it from there?

k-rajat19 commented 1 month ago

That's just because all CLI arguments are strings. But we probably don't need to say that in the types, so real fix is probably to remove it from there?

that sounds more reasonable but it will be breaking for those who are already passing string? that's why I thought to make change in the doc instead of changing types 😅

SimenB commented 1 month ago

I doubt anybody's passing it, but if they do, it should be easy enough to change. This only changes the types anyways.

Mind adding a changelog entry?

github-actions[bot] commented 2 weeks ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.