jestjs / jest

Delightful JavaScript Testing.
https://jestjs.io
MIT License
44.21k stars 6.46k forks source link

[Bug]: Type definitions exported by @jest/test-result refer to dev dependency #15314

Open johnameyer opened 1 month ago

johnameyer commented 1 month ago

Version

29.7.0

Steps to reproduce

  1. npm i @jest/test-result@^29.7.0
  2. Import from package directly or indirectly in a typescript file e.g. echo "import * as testResult from '@jest/test-result';" > index.ts
  3. Attempt to compile npx tsc index.ts

https://stackblitz.com/edit/node-my9zod?file=index.ts,package.json,package-lock.json

(Real use case) https://stackblitz.com/edit/node-ru6fy9?file=index.ts,package.json

Expected behavior

No Typescript compilation errors

Actual behavior

Typescript error thrown

node_modules/@jest/test-result/build/index.d.ts:14:27 - error TS2307: Cannot find module 'jest-resolve' or its corresponding type declarations.

14 import type Resolver from 'jest-resolve';
                             ~~~~~~~~~~~~~~

Found 1 error in ../../node_modules/.pnpm/@jest+test-result@29.7.0/node_modules/@jest/test-result/build/index.d.ts:14

Additional context

The type declarations of https://www.npmjs.com/package/@jest/test-result import from 'jest-resolve' despite it only being depended on as a dev dependency.

Environment

System:
    OS: Linux 5.0 undefined
    CPU: (6) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
github-actions[bot] commented 5 days ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

SimenB commented 4 days ago

Happy to take a PR for this 👍