lucasfcosta
commented
5 years ago Hi @iyobo,
This issue is somewhat related to https://github.com/facebook/jest/pull/8654.
It's great that you've raised this issue, but I'd suggest changing the description a bit since it's not an accurate description of the actual problem.
The actual problem is not that the error in beforeAll gets hidden, the problem is that even though beforeAll fails, the subsequent tests still run. This problem is the same as the one we've had with beforeEach in https://github.com/facebook/jest/issues/2867.
Reproducible
You can see a minimal reproducible version on top of the current master in here and run it with yarn repro.
beforeAll(async () => {
throw new Error('Error in beforeAll');
});
describe('tests', () => {
it('test 1', () => {
console.log('first: runs!');
});
it('test 2', () => {
console.log('second: runs!');
});
});The behaviour in jest-jasmine2
In jest-jasmine2 the error thrown by beforeAll will be used as the error for the subsequent tests and they will still run.
Current log of the reproducible in `jest-jasmine2`
``` ➜ yarn repro yarn run v1.15.0 $ yarn jest e2e/__tests__/beforeAllAbortsTests.test.ts $ node ./packages/jest-cli/bin/jest.js e2e/__tests__/beforeAllAbortsTests.test.ts FAIL e2e/__tests__/beforeAllAbortsTests.test.ts tests ✕ test 1 (5ms) ✕ test 2 (1ms) ● tests › test 1 Error in beforeAll 1 | beforeAll(async () => { > 2 | throw new Error('Error in beforeAll'); | ^ 3 | }); 4 | 5 | describe('tests', () => { at Object.The behaviour in jest-circus
In jest-circus the error thrown by beforeAll will be used as the error for the subsequent tests and they will not be executed.
Current log of the reproducible in `jest-circus`
``` ➜ JEST_CIRCUS=1 yarn repro yarn run v1.15.0 $ yarn jest e2e/__tests__/beforeAllAbortsTests.test.ts $ node ./packages/jest-cli/bin/jest.js e2e/__tests__/beforeAllAbortsTests.test.ts FAIL e2e/__tests__/beforeAllAbortsTests.test.ts tests ✕ test 1 (3ms) ✕ test 2 ● tests › test 1 Error in beforeAll 1 | beforeAll(async () => { > 2 | throw new Error('Error in beforeAll'); | ^ 3 | }); 4 | 5 | describe('tests', () => { at e2e/__tests__/beforeAllAbortsTests.test.ts:2:9 at asyncGeneratorStep (e2e/__tests__/beforeAllAbortsTests.test.ts:3:103) at _next (e2e/__tests__/beforeAllAbortsTests.test.ts:5:194) at e2e/__tests__/beforeAllAbortsTests.test.ts:5:364 at e2e/__tests__/beforeAllAbortsTests.test.ts:5:97 ● tests › test 2 Error in beforeAll 1 | beforeAll(async () => { > 2 | throw new Error('Error in beforeAll'); | ^ 3 | }); 4 | 5 | describe('tests', () => { at e2e/__tests__/beforeAllAbortsTests.test.ts:2:9 at asyncGeneratorStep (e2e/__tests__/beforeAllAbortsTests.test.ts:3:103) at _next (e2e/__tests__/beforeAllAbortsTests.test.ts:5:194) at e2e/__tests__/beforeAllAbortsTests.test.ts:5:364 at e2e/__tests__/beforeAllAbortsTests.test.ts:5:97 Test Suites: 1 failed, 1 total Tests: 2 failed, 2 total Snapshots: 0 total Time: 1.036s Ran all test suites matching /e2e\/__tests__\/beforeAllAbortsTests.test.ts/i. error Command failed with exit code 1. ```Multiple failing beforeAll hooks
Both in jest-circus and jest-jasmine2, if there are multiple beforeAll hooks and one of them fails, all the subsequent beforeAll and afterAll hooks will still run. The same behaviour is valid for afterAll: all of them will still run even if one fails.
beforeAll(async () => {
throw new Error('Error in beforeAll');
});
beforeAll(async () => {
throw new Error('Error in second beforeAll');
});
describe('tests', () => {
it('test 1', () => {
console.log('first: runs!');
});
it('test 2', () => {
console.log('second: runs!');
});
});
afterAll(async () => {
throw new Error('Error in first afterAll');
});
afterAll(async () => {
console.log('second afterAll still runs');
});Actual Desired Behaviour (?)
I was planning on also tackling this since it's very related to that PR I've recently done, but I think it would be helpful to agree on the actual desired behaviour for the edge-case described above before starting to implement it (the same we have run into in the other PR).
IMO all beforeAll hooks should run regardless of whether the previous beforeAll hooks have failed. If a beforeAll hook has failed, none of the subsequent beforeEach, tests, or afterEach should run, but the afterAll hooks should.
The suggestion above would make the behaviour more similar to beforeEach and afterAll, which would be more consistent (IMO).
iyobo
philiiiiiipp
krzkaczor
khitrenovich
sonic1981
FrederikP
github-actions[bot]
🐛 Bug Report
The beforeAll hook hides errors.
To Reproduce
Expected behavior
Errors thrown in beforeAll hooks should be thrown and not get swallowed up. Such a failure should also kill further testing for that file/parallel process given that whatever failed in beforeAll would be crucial for continued testing of that parallel.
Run
npx envinfo --preset jestPaste the results here: