Open cameracker opened 5 years ago
Hi! I managed to figure it out by reading over your lovely example project :)
I was missing these properties:
"modulePathIgnorePatterns": [
"packages/.*/build"
],
"projects": ["<rootDir>/packages/*"],
Thanks!!
@CameronAckermanSEL i'm getting this at the moment. Might you know why the solution above worked? and what might have caused this, this solution doesn't seem work for me. I'm on lerna v2
@CameronAckermanSEL I get that error too but it happens when I import a module from a custom library
> jest --no-cache
jest-haste-map: Haste module naming collision: my-lib
The following files share their name; please adjust your hasteImpl:
* <rootDir>\dist\my-lib\package.json
* <rootDir>\projects\my-lib\package.json
PASS src/app/services/test.service.spec.ts
PASS projects/my-lib/src/lib/components/button/button.component.spec.ts
FAIL src/app/app.component.spec.ts
β Test suite failed to run
TypeError: dupMap.get is not a function
3 | import { TestService } from './services/test.service';
4 | import { of } from 'rxjs';
> 5 | import { MyLibModule } from 'my-lib';
| ^
6 |
7 | jest.mock("./services/test.service");
8 |
at ModuleMap._getModuleMetadata (node_modules/jest-haste-map/build/ModuleMap.js:231:14)
at Object.<anonymous> (src/app/app.component.spec.ts:5:1)
Test Suites: 1 failed, 2 passed, 3 total
Tests: 3 passed, 3 total
Snapshots: 0 total
Time: 6.013s
This is the .spec.ts file
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { AppComponent } from './app.component';
import { TestService } from './services/test.service';
import { of } from 'rxjs';
import { MyLibModule } from 'my-lib';
jest.mock("./services/test.service");
describe('AppComponent', () => {
let component: AppComponent;
let fixture: ComponentFixture<AppComponent>;
let testService: TestService;
beforeEach(async(() => {
TestBed.configureTestingModule({
declarations: [AppComponent],
imports : [MyLibModule],
providers: [TestService]
})
.compileComponents();
}));
beforeEach(() => {
testService = TestBed.get(testService);
jest.spyOn(testService, "getResource").mockReturnValue(
of({
username: 'Brent'
})
);
fixture = TestBed.createComponent(AppComponent);
component = fixture.componentInstance;
fixture.detectChanges();
});
it('should create', () => {
expect(component).toBeTruthy();
});
});
Facing the same issue, I have my own custom library as shared project on angular. I have all necessary things like moduleNameMapper
but still the issue is there.
think i might have found what caused this. If you make any updates to package-lock this happens π , when i removed any changes on my parent package lock. This error got resolved
We should never have TypeError
s internally, no matter what your config is. Can anyone provide a full, minimal reproduction we can clone and run locally to see the error?
Create a library project along with normal angular application
ng new my-workspace --createApplication="false"
cd my-workspace
ng generate application my-app
ng generate library my-lib
Output path for library project will be dist/my-lib
and for application it should dist/my-app
In main tsconfig.json "paths": { "@custom/my-lib": [ "dist/my-lib" ], "@custom/my-lib/*": [ "dist/my-lib/*" ] }
In jest.config.js add configuration for path mapper as moduleNameMapper: pathsToModuleNameMapper(compilerOptions.paths || {}, { prefix: '<rootDir>/' })
And in one of the spec/test file use the library as import { Something} from '@custom/my-lib'
This fails at the above import with the error as dupMap.get is not a function
.
PS: Jasmine framework works fine for same test
I have encountered this too in a mixed TypeScript and JavaScript project that uses Vue. As with the other posters, this happens when importing a class from another custom library that is included as a git submodule, referenced from package.json
using file:
syntax. The error occurs several layers deep in the import hierarchy, not from an import from the .spec file itself. So the import hierarchy is:
thing.spec.ts
import { MyComponent } from 'MyComponent.vue'
import { SomeModel } from '@my-org/package-name'
import { AnotherModel } from './local_file'
import { Utility } from '@my-org/another-package'
The error is raised at the fourth level down, when importing Utility
from @my-org/another-package
:
TypeError: dupMap.get is not a function
> 1 | import { Utility } from '@my-org/another-package'
| ^
at ModuleMap._getModuleMetadata (node_modules/jest-haste-map/build/ModuleMap.js:231:14)
at Object.<anonymous> (--redacted local path--.js:1:1)
@isumeetk thanks, but could you do those steps in a repo and publish that? I tried to follow your steps but step 3 is unclear (paths
is already in the file - should I replace or add to it?), step 4 is unclear (should I create this file? What is pathsToModuleNameMapper
?) and step 5 is unclear since I don't know which file to make the change.
I could probably figure out these things if I spent some time on it, but it's a higher barrier than need be here. Either a repo I can clone, or a repl.it/codesandbox would be ideal. Ideally I should be able to clone, install, and run to see the error
PS: Jasmine framework works fine for same test
Not sure what this means - jasmine instead of jest, or using jest-jasmine (which is the default test runner within jest)?
Well this is interesting, while creating a repo to reproduce something made it work, both in reproducing repo and the my main repo. Still for people who want to go through the working structure here is the repo https://github.com/isumeetk/jest-angular-sample
I have the same issue when I import a module from a custom library, just like @franjpr. Any solution?
For the umpteenth time, if you want it fixed somebody needs to put together a repository, or some other reproduction, where we can see the error.
https://www.snoyman.com/blog/2017/10/effective-ways-help-from-maintainers
not sure if this will help, but i am seeing this issue on a lerna repo i'm setting up. it seems to be an issue with symlinks and copies (still figuring it out since i inherited the code). deleted some symlinks/copies before running tests made this issue go away.
main issue is that the dupMap
object is not a Map
instance. here's what it looks like for me:
[
[
"g",
[
[
"packages/components/lib/utils/package.json",
1
],
[
"packages/utils/package.json",
1
]
]
]
]
i'm guessing something isn't creating a Map
object in this._raw.duplicates.get(name)
properly?
Hi all,
Here is a minimal repository where this bug is reproduced: https://github.com/WilliamChelman/angular-jest-bug-repro
How-to:
npm ci
npm t
Cannot find module '@me/lib-a' from 'lib-b.component.ts' Require stack: projects/me/lib-b/src/lib/lib-b.component.ts projects/me/lib-b/src/lib/lib-b.component.spec.ts
npm run build-all
npm t
The name
@me/lib-a
was looked up in the Haste module map. It cannot be resolved, because there exists several different files, or packages, that provide a module for that particular name and platform. The platform is generic (no extension). You must delete or blacklist files until there remains only one of these:
/home/william/Dev/other/angular-jest-bug/dist/me/lib-a/package.json
(package)/home/william/Dev/other/angular-jest-bug/projects/me/lib-a/package.json
(package)
Some of the leads that were explored to fix this, but to no avail and usually end up with the "dupMap.get is not a function" error:
Solution that did work but felt dirty: change projects/me/lib-a/ng-package.json to
{
"$schema": "../../../node_modules/ng-packagr/ng-package.schema.json",
"dest": "../../../node_modules/@me/lib-a", // here
"lib": {
"entryFile": "src/public-api.ts"
}
}
So that the build is put in the node_modules directly, so then it's considered as any other external lib when tests are launched.
To whoever read this, have a great day :smile:
EDIT: doesn't really reproduce the dupMap.get error unfortunately, but leaving this at least for the ng-package.json hack that might help someone.
@WilliamChelman I'm unable to reproduce. I get the haste errors you note, but
moduleDirectories: ['node_modules', 'dist']
makes no differencemodulePathIgnorePatterns: ['/projects']
makes it find no testsmodyfing paths in tsconfig
entails so I didn't touch that part.I haven't done any angular since v1, so there might be some detail I'm missing.
Could you add a commit to that repo so that I can run npm cit
and get the dupMap.get is not a function
error?
For some reason I'm currently unable to reproduce the dupMap.get error, even if it was that same error that brought me here... But now that I think of it (after sleeping a bit), it seems like the issue I have might be more for ts-jest in fact, since it looks like it is the tsconfig file that doesn't bode well with module resolution in this context. I'll see to create an issue on their side instead, thank you for your time @SimenB .
I still think this is a bug in Jest somehow, if nothing else we should provide a better error. So if you figure out why you get the error please report back so we can improve things π
@SimenB just ran into this same problem, and it appears that I needed to ignore my output folders as @CameronAckermanSEL mentioned.
modulePathIgnorePatterns: ["packages/*/dist"]
for me, as I have a mono-repo where all package sources are in packages/**/src/*
and packages/**/dist
is where they build to.
Hopefully someone else will find this helpful :)
I was able to get rid of this error by calling jest --clearCache, probably because I had fixed one of the other causes listed above, but the cache retained the error?
I'm working in an Angular CLI project with an application and a library. It get it working by:
... "dest": "../../node_modules/@my-domain/my-library", ...
"paths": { "@my-domain/my-library": [ "../node_modules/@my-domain/my-library" ] }
I just resolved same problem with angular project by this config:
// jest.config.js
module.exports = {
preset: 'jest-preset-angular',
setupFilesAfterEnv: ['<rootDir>/src/setupJest.ts'],
testRegex: ...,
roots: ['<rootDir>/src'],
modulePaths: ['<rootDir>/dist'],
};
More at Medium
I ran into this same issue today. For me the issue was related to using yalc to develop multiple dependent repos.
The problem disappeared after I removed all yalc installations (yalc remove --all
in every repo and then verified that yalc installations show
was empty)
I have the same issue in my Angular project. For some reason, when I remove package.json
in (projects/my-project
, not the one in my root), the error is gone.
I got this error when I added a path mapping to my project from my tsconfig.spec.json
:
{
"compilerOptions": {
"paths": {
"my-project": ["projects/my-project/src/public-api.ts"]
}
}
}
And, my jest.config.js
:
module.exports = {
moduleNameMapper: {
"my-project": "<rootDir>/projects/my-project/src/public-api.ts"
},
};
However, I need my package.json
there because it is the one that gets packaged by Angular.
My workaround was to rename the path mapping of my-project
to my-project-api
, which fixed the issue.
Can you put together a reproduction? I'd like to fix this so people don't need any workarounds (or at least give a clearer/actionable error)
I have found the issue. I will describe it here and post a reproducible demo in a bit. Here is what happens:
have the same issue
I encountered this issue today and packed it as a reproduction. I'm building my own typescript project template. I uses ts-jest. What I'm doing is trying to test the packed package. So my run script uses 'npm pack' to pack the package, extract it in a directory, 'npm link' from there, then install it back locally. Then I run a test that import my package using an absolute path as if from 'npm install'.
To reproduce the issue:
git clone https://github.com/bingtimren/ts-proj-template.git
cd ts-proj-template/
git checkout jest-issue-9021
npm install
npm run build
npm run test
After running into this issue myself, I encountered this helpful PR from the "isomorphic git" repo where they fixed this problem. While the PR doesn't contain much of an explanation, looking at it's very simple change was enough for me to identify the fix in my own repo. In my case, I have a monorepo using yarn workspaces and lerna where package B
imported package A
. I had failed to configure the jest modulePathIgnorePatterns
to include the build output of package A
. When I added the build output of package A
to modulePathIgnorePatterns
, this error goes away. If I remove the build output of package A
from modulePathIgnorePatterns
, this error re-appears.
The error only appears for package B's
tests. My assumption is that, somehow, when a package B
test is attempting to locally import package A
(again, this is a monorepo using lerna), jest is getting confused by the presence of the package A
build in the package A
source folder. I don't have a reproduction to share at this time, unfortunately.
The diff from the "isomorphic git" fix which helped me solve this issue looks like:
module.exports = {
+ modulePathIgnorePatterns: ['<rootDir>/website'],
testRegex: '/__tests__/(server-only\\.)?test-[^\\/]+\\.js',
moduleNameMapper: {
'^isomorphic-git$': '<rootDir>/src'
cc @SimenB
Interesting stuff. Thanks for the reproduction @bingtimren, sorry I missed it when you posted it!
If I run the tests with -i
(i.e. forcing not to use workers) we get the correct error
The name `@bingsjs/ts-proj-template` was looked up in the Haste module map. It cannot be resolved, because there exists several different files, or packages, that provide a module for that particular name and platform. The platform is generic (no extension). You must delete or exclude files until there remains only one of these:
* `/Users/simen/repos/ts-proj-template/build/pack/package/package.json` (package)
* `/Users/simen/repos/ts-proj-template/package.json` (package)
So there's something wrong with (de)serialization of the Map
s between workers. Will dig some more into this, but for people encountering this - running with -i
(short for --run-in-band
) should help you debug
Reverting the jest-runner
parts of #8237 fixes the issue
I currently have a lerna project, this issue went away for me after upgrading to jest version 27.4.5.
Error:
TypeError: dupMap.get is not a function
5 |
6 | import ua from '@searchfe/user-agent';
> 7 | import compare from 'versions-compare';
Fix:
i output a log in this file ('node_modules/jest-haste-map/build/ModuleMap.js:209:14')
name === 'versions-compare' && (console.log(name, ...dupMap));
this._assertNoDuplicates(
name,
_constants.default.GENERIC_PLATFORM,
`supportsNativePlatform,`
dupMap.get(_constants.default.GENERIC_PLATFORM)
);
found array
versions-compare [
'g',
[
[ 'dist/modules/versions-compare/package.json', 1 ],
[ 'amd_modules/versions-compare/package.json', 1 ]
]
]
because it found 2 pacakges, The answer above give me clue https://github.com/facebook/jest/issues/9021#issuecomment-539369466 @cameracker
Fixed ππππ
modulePathIgnorePatterns: [
"dist"
],
Meet this problem on an Angular app with some Angular libs, problem solved after adding moduleNameMapper
to root jest.config.js
.
see: https://kulshekhar.github.io/ts-jest/docs/getting-started/paths-mapping/
Let's says we have a Angular lib placed at projects/my-lib
, your root tsconfig
paths may look like this
{
...others
"compilerOptions": {
"paths": {
"@my-scope/my-lib": [
"dist/my-lib/my-scope-my-lib",
"dist/my-lib"
]
}
}
}
Your root jest.config.js
will need to set
roots
to ['<rootDir>/src']
moduleNameMapper
to map @my-scope/my-lib
to projects/my-lib/src/public-api
module.exports = {
roots: ['<rootDir>/src'],
moduleNameMapper: {
'@my-scope/my-lib': '<rootDir>/projects/my-lib/src/public-api',
},
};
And for my-lib jest.config.js
set
roots
to ['<rootDir>/projects/my-lib']
module.exports = {
roots: ['<rootDir>/projects/my-lib'],
};
Facing same issue. Anyone solved it?
I have the same issue in my Angular project. For some reason, when I remove
package.json
in (projects/my-project
, not the one in my root), the error is gone.I got this error when I added a path mapping to my project from my
tsconfig.spec.json
:{ "compilerOptions": { "paths": { "my-project": ["projects/my-project/src/public-api.ts"] } } }
And, my
jest.config.js
:module.exports = { moduleNameMapper: { "my-project": "<rootDir>/projects/my-project/src/public-api.ts" }, };
However, I need my
package.json
there because it is the one that gets packaged by Angular.My workaround was to rename the path mapping of
my-project
tomy-project-api
, which fixed the issue.
I met the same problem and the error disappeared after I changed the packageJson.name of the root directory. But I need to keep this root packageJson.name. Any update about this issue?
I'm using jest@29.5.0, and here is my tsconfg and jest config:
"compilerOptions": {
"baseUrl": ".",
"paths": {
"my-root-package": "."
}
}
modules.exports = {
rootDir: __dirname,
roots: [__dirname],
moduleNameMapper: {
'^my-root-package$': '<rootDir>'
}
};
Error:
TypeError: dupMap.get is not a function 5 | 6 | import ua from '@searchfe/user-agent'; > 7 | import compare from 'versions-compare';
Fix:
i output a log in this file ('node_modules/jest-haste-map/build/ModuleMap.js:209:14')
name === 'versions-compare' && (console.log(name, ...dupMap)); this._assertNoDuplicates( name, _constants.default.GENERIC_PLATFORM, `supportsNativePlatform,` dupMap.get(_constants.default.GENERIC_PLATFORM) );
found array
versions-compare [ 'g', [ [ 'dist/modules/versions-compare/package.json', 1 ], [ 'amd_modules/versions-compare/package.json', 1 ] ] ]
because it found 2 pacakges, The answer above give me clue #9021 (comment) @cameracker
Fixed ππππ
modulePathIgnorePatterns: [ "dist" ],
on a gatsbyjs
project, this worked for me
Hoiw about adding (for these who are using yalc):
"modulePathIgnorePatterns": ["dist", ".yalc"],
?
This solve the issue for me. If I use yalc remove --all like @vilvai mentioned, I'll loose the dependencies and my project won't run successfully anymore.
I was gonna look into fixing the error in this case now, but the reproduction from https://github.com/jestjs/jest/issues/9021#issuecomment-787544325 is unfortunately deleted. Does anybody else have a small reproduction I can test with?
I ran into this same issue today. For me the issue was related to using yalc to develop multiple dependent repos.
The problem disappeared after I removed all yalc installations (
yalc remove --all
in every repo and then verified thatyalc installations show
was empty)
@vilvai, almost 4 years later this comment just saved my day!
Hoiw about adding (for these who are using yalc):
"modulePathIgnorePatterns": ["dist", ".yalc"],
? This solve the issue for me. If I use yalc remove --all like @vilvai mentioned, I'll loose the dependencies and my project won't run successfully anymore.
@vladyn, this indeed solves it in a cleaner way.
However, in my case, I thought I got rid of the yalc imported dependencies and reverted to the main package as I was done working on it and was about to commit the package depending on it. It seems that I need to go back to yalc's documentation and see how to properly clean up (ie. yalc remove --all
) and probably see if a commit hook exists to prevent putting a mess in the repo too.
π Bug Report
Running a jest test results in a test build failure:
When console logging
dupMap
at the source location,dupMap
is undefined. I don't see a control flow where this is possible because when dupMap is declared, it is set to EMPTY_MAP if it's value would be undefined.The error is also bound to a material-ui style object, which doesn't make much sense.
To Reproduce
Steps to reproduce the behavior:
I'm afraid I don't have a reproduction. I'm using
lerna
andmaterial-ui
in jest. The library I'm experiencing the issue with is dependent on another library in my mono repo.Expected behavior
The test runs without problems
Link to repl or repo (highly encouraged)
Unavailable, sorry
envinfo
My jest config: