search

jesus2099 / konami-command

power‐ups for various web sites
119 stars 25 forks source link

Greasemonkey v4: xmlHttpRequest.open no longer accept path without protocol and host #372

Open jesus2099 opened 6 years ago

jesus2099 commented 6 years ago

Still works in Vivaldi but I’ll make a work‐around so that it works in both.

jesus2099 commented 6 years ago

It seems to be a Greasemonkey v4 for Firefox v57 bug, actually (#369).

jesus2099 commented 6 years ago

I have reopened the ticket as several other scripts should be blocked by this GM v4 regression (greasemonkey/greasemonkey#2771). If they fix it, I’ll revert my changes.

jesus2099 commented 6 years ago

I think I have work arounded all my scripts now. I leave this ticket open to revert those changes once the regression is fixed by Greasemonkey.

Martii commented 6 years ago

@jesus2099 Does 4.2beta1 work for you? It does not for me... it seems to break the xhr in my scripts completely. I do see a PR upstream at 2792 awaiting though.

jesus2099 commented 6 years ago

The PR seems to be solely about the async parameter. Beta version is supposed to work with our /paths. I don’t really use Firefox but, as soon as I have some time, I’ll install their beta version too and revert my change on some scripts. But I have not done it yet.

Martii commented 6 years ago

Seems to be functional in 4.2beta2 now. Most likely that commit was the repair needed. Don't see any other related commits that could have unbusted it.

jesus2099 commented 6 years ago

Thanks very much @Martii. I will wait for the release and revert my work-around. 😁

jesus2099 commented 3 years ago

I tried coming back to relative path for xhr.open() and it worked in Greasemonkey. I will make sure it still works in Violentmonkey and Tampermonkey before reverting everywhere.