search

jesus2099 / konami-command

power‐ups for various web sites
123 stars 27 forks source link

Unqueue button is hard to click and does not really always unqueue #421

Closed jesus2099 closed 2 years ago

jesus2099 commented 5 years ago

@drsaunde told me this problem, now it happened to me.

jesus2099 commented 2 years ago

I understood, there is a distinct behaviour expected but which is not possible with the current conditions:

If script clicks Unqueue button (it happens after each merge), it will launch the merge immediately:

https://github.com/jesus2099/konami-command/blob/dd587649210c10f4ec4a94543ac58844121723d2/mb_MASS-MERGE-RECORDINGS.user.js#L280-L282

https://github.com/jesus2099/konami-command/blob/dd587649210c10f4ec4a94543ac58844121723d2/mb_MASS-MERGE-RECORDINGS.user.js#L840-L851

If user clicks Unqueue button, it will be removed from queue:

https://github.com/jesus2099/konami-command/blob/dd587649210c10f4ec4a94543ac58844121723d2/mb_MASS-MERGE-RECORDINGS.user.js#L863-L866

jesus2099 commented 2 years ago

I could not reproduce with old version, so I am not 100% sure, but I think it should not happen any more.