y-van-z/yvanzo’s All shook up links

[jesus2099]

I am still working on this @yvanzo big set of features #244.

• Branch: https://github.com/jesus2099/konami-command/commits/%23244_y-van-z_all-shook-up-links
• Yvanzo's help: https://github.com/jesus2099/konami-command/pull/244#issuecomment-226116075

This will be done when I will merge above branch into master, discarding all changes to other files than mb_ALL-LINKS.user.js.

See branch commits, diff Compare branch with master, diff

Switch scripts in browser (Ctrl+click or middle-click):

• Old master version: code, install
• New version (yvanzo + my integration fixes): code, install

Remember to (I made sure my previous checklist was included):

• [x] Keep #500 improvements - c98b8da34ba228d940d10987bed70de6fff37c7e
• [x] Keep #558 - c82fac6e5945b3eba44df380065d2abdbe57e897
• [x] Simplify %language% syntax e6b47381ff28313ed8cf8a2763e58d51ad3bad59
• [x] #599
• [ ] #591
• [ ] Restore all my appropriate searches
• [ ] Restore all my cross-charset searches with #631
• [x] Restore my release event searches (#45)
• [ ] Replace tokens in link labels too (not only in URL)
• [ ] Loop in all catalogue numbers (needs tokens in labels, first)
• [ ] Restore Latin name alternative search for non‐Latin artists: See %artist-latin-script-name% in Yvanzo's help
• [ ] Make a mobile friendly WD→WP language setup popup
• [x] ~Check that all improvements after this branch base are still included: https://github.com/jesus2099/konami-command/commits/master/mb_ALL-LINKS.user.js~ OK, since ea42edc16add518c36c9f9922fe3e0e07d50e51d (parent of d47c61581c1eee475a2979c45f487c2b3a9392e9 merge) there is only #500's 3 commits
• [x] #776
• [x] #782
• [x] #783
• [x] #799

[jesus2099]

It’s superb that #244 × 2 = #488.

[jesus2099]

Removed the special merge technique from OP:

git checkout master
git checkout #244_y-van-z_all-shook-up-links mb_INLINE-STUFF.user.js

(it seems that using --patch would be if I wanted to pick changes instead of taking all file)

I tested this technique for updating .gitignore and it does not show as a branch merge. I want to show the Yvanzo branch merging into master, explicitely, in history.

[jesus2099]

Hi @yvanzo,

Could you tell me if I understood right in my latest fbc901543b44384c58fcf753175eff2777a3789a?

Every time I update this #244 branch, GitHub suggests to create a pull request (PR, merge request). Do you think it would be better, maybe?

[yvanzo]

Hi @jesus2099,

Adding parentNode seems to be correct but I’m not so sure about the added sidebar in this commit. IIRC the idea was to insert them next to other search links, maybe even in the searchLinks list? I don’t see them appearing anyway. Wasn’t there a dialog to allow setting them too?

About the pull request workflow, it’s only useful when you want feedback from someone else before merging.

Thanks again to keep caring about user scripts!

[jesus2099]

Yes, there is little bit of inconsistencies between the (I guess) similar addHiddenLinks(), addSearchLinksSection(sectionPath, parentNode) and addUserLinks(parentNode).

I will check that in the future. User links are empty per default, there used to be an ugly prompt to edit them. They would be good before the standard search links, because they are user specifics, user needs.