search

jesus2099 / konami-command

power‐ups for various web sites
122 stars 26 forks source link

My compatibility \r\n now causes small visual glitch in Windows Vivaldi #490

Closed jesus2099 closed 4 years ago

jesus2099 commented 4 years ago

I have noticed with FUNKEY CAA that the \r\n that I use for new lines in tooltips (title attribute) are now causing issue with my latest Vivaldi upgrade. So it may concern all my scripts using \r\n in tooltips on Chromium based browsers on Windows, at least. image It displays this small CR (probably ␍ U+240D SYMBOL FOR CARRIAGE RETURN) instead of \r.

If I remove \r and leave only \n it's OK, but the \r part was there for Linux and Mac, so I wonder what happens to them… 🤔

OS Browser \r\n \r \n
Windows Firefox :+1: :+1: :+1:
Windows Vivaldi \r CR but \n OK new line CR and no new line :+1:
Ubuntu Chrome \r CR but \n OK new line CR and no new line :+1:

Update 2020-09-28

I don't see any more problems in Linux Chromium nor on Windows Vivaldi (tested alert, console and tooltip). So it was a temporary cross-platform Chrome/Chromium glitch. As I already started removing my \r, I will just go on cleaning them up as they are redundant with \n that, apparently, work everywhere.

Fixing status

jesus2099 commented 4 years ago

Ubuntu Chrome acts the same as Windows Vivaldi! Thanks @reosarevok!

jesus2099 commented 4 years ago

MERGE HELPOR 2 does use \r but in alerts, in text areas and some places that are not tool tips (title) and that don't seem to cause any issues.

jesus2099 commented 4 years ago

Fixed for PENDING EDITS, where all \r were only in some dead code, anyway.

jesus2099 commented 4 years ago

Fixed for INLINE STUFF track tooltip.

jesus2099 commented 4 years ago

kasi_PLAIN-TEXT-LYRICS's \r must be kept:

https://github.com/jesus2099/konami-command/blob/e9bc14ebf1f6c1a867f8420fe8a24ddfe427bd47/kasi_PLAIN-TEXT-LYRICS.user.js#L214

jesus2099 commented 4 years ago

Same for mb_ELEPHANT-EDITOR.