[MBS] Adapt to React hydrate redraw of recording list - Githubissues

jesus2099 / konami-command

power‐ups for various web sites

120 stars 25 forks source link

[MBS] Adapt to React hydrate redraw of recording list #537

Closed jesus2099 closed 3 years ago

jesus2099 commented 3 years ago

New div.recording-list on top of table.tbland (deferred?) redrawing(/hydrate?) of its content:

https://github.com/metabrainz/musicbrainz-server/commit/53fc7e3c18ff7fd4231cb1461ee58f01f29c0f2e#diff-8faa5353a1c84c9ee6dcf90be9bd62c669390f97c07ad8cf8401a8cee0bc7a6fR137-R140

export default (hydrate<Props>(
  'div.recording-list',
  RecordingList,
): React.AbstractComponent<Props, void>);

This redraws the DOM at any time, thus wiping all what userscripts may have added.

Workaround

One way to cope with that appears to be waiting for any p.loading-message to disappear, when DOM may be stable again.

For event listeners, attach them to the body, instead.

Happens in:

/artist/<mbid>/recordings
/recording/merge

Sub-issues

mb_COLLECTION-HIGHLIGHTER

[x] Most highlights broken in merge page caused by recent React redraw #517

mb_MERGE-HELPOR-2

[x] Remove “Removed from merge” feature #497
~~Add AcoustID in MERGE HELPOR 2 for recordings merge #516~~
[x] No more info on recording merge page #518
[x] No more edit notes #535

mb_SUPER-MIND-CONTROL-II-X-TURBO

[x] Double click to submit merge does not trigger #550

jesus2099 commented 3 years ago

Detach mb_MERGE-HELPOR-2 #516 as it’s a new feature request.