jesus2099 / konami-command

power‐ups for various web sites
122 stars 26 forks source link

Remove the more "destructive" scripts from GF / OUJS #572

Open jesus2099 opened 3 years ago

jesus2099 commented 3 years ago

↖ #396 – GF and OUJS: Abandon mirrors


Some scripts like the MASS MERGE RECORDINGS are actually queuing edits (or are inciting edits). They should not be too easy to find and install.

jesus2099 commented 2 years ago

I have removed MASS MERGE RECORDINGS from GF and OUJS, as it was no longer updated by them.

Here is a great template for removing the other scripts (#396):

// ==UserScript==
// @name         mb. MASS MERGE RECORDINGS
// @version      2021.7.31.666
// @description  musicbrainz.org: Merges selected or all recordings from release A to release B
// @namespace    https://github.com/jesus2099/konami-command
// @supportURL   https://community.metabrainz.org/t/merge-duplicate-recordings-between-two-editions-of-the-same-album-with-mb-mass-merge-recordings/203168?u=jesus2099
// @downloadURL  https://github.com/jesus2099/konami-command/raw/master/mb_MASS-MERGE-RECORDINGS.user.js
// @author       jesus2099
// @license      CC-BY-NC-SA-4.0; https://creativecommons.org/licenses/by-nc-sa/4.0/
// @license      GPL-3.0-or-later; http://www.gnu.org/licenses/gpl-3.0.txt
// @since        2011-12-13; https://web.archive.org/web/20131103163401/userscripts.org/scripts/show/120382 / https://web.archive.org/web/20141011084015/userscripts-mirror.org/scripts/show/120382
// @include      /^https?:\/\/(\w+\.)?musicbrainz\.org\/release\/[a-f0-9]{8}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{12}(\/(disc\/\d+)?)?(\?tport=\d+)?(#.*)?$/
// @run-at       document-end
// ==/UserScript==
"use strict";

if (confirm("MASS MERGE RECORDINGS is no longer available outside its official repo. Please go to GitHub.com/jesus2099/konami-command to install the latest version, by clicking the RAW button.")) {
    location.assign("https://github.com/jesus2099/konami-command/blob/master/mb_MASS-MERGE-RECORDINGS.user.js");
}
Martii commented 2 years ago

OUJS didn't like my @grant GM_info any more (not valid or supported)

See https://sourceforge.net/p/greasemonkey/wiki/GM_info/ i.e. you don't have to do it... therefor not valid syntax for .user.js. Been this way the whole time of its existence. :smiley:

jesus2099 commented 2 years ago

Wow I never saw those docs you've made! They are really great!

On https://sourceforge.net/p/greasemonkey/wiki/GM_log/ I see an example where it says you need grant.

In fact in https://sourceforge.net/p/greasemonkey/wiki/Metadata_Block/#grant I can see which GM_functions need it.

Thanks very much, @Martii.

I noticed that scripts worked whether I write grant or not but never saw a doc saying in which case it's needed exactly.

Martii commented 2 years ago

but never saw a doc saying in which case it's needed exactly.

I filled in GM_info just recently because of another user who inquired about the filtering. The err message is a catch all for invalid and unsupported keys as well. If there is ever support needed for a new key please feel free to let us know on GH dev with lots of citation so we can add it in. :smile:


I see an example where it says you need grant

It's labeled as Access in the documentation under Syntax as well.

jesus2099 commented 2 years ago

Now that I know grant is not needed for GM info, only now, I find the doc saying so (but in a way I didn't understand what it meant before knowing): https://wiki.greasespot.net/@grant