search

jesus2099 / konami-command

power‐ups for various web sites
117 stars 25 forks source link

Edit note added in relationship editor is lost upon submission #751

Closed nimuxoha closed 1 year ago

nimuxoha commented 1 year ago

When using ELEPHANT EDITOR to add edit notes in the new relationship editor (still in beta but might soon be released) the note is suddenly cleared and omitted from submitted edits once "enter edit" is clicked or when SHIFT Clicking on a stored note.

It can be worked around by manually typing something in the edit note field. So it seems not to detect the note when it's added by the script alone.

kellnerd commented 1 year ago

@jesus2099 I had the same problem with my userscripts, edit notes are now React-ified too. My solution: https://github.com/kellnerd/musicbrainz-scripts/commit/38e700956b652c9efcc13a35297e4da9e744e330 & https://github.com/kellnerd/musicbrainz-scripts/commit/bf7da06d3cb397d2bd12fb230d9c7592b2a17f90

jesus2099 commented 1 year ago

Thanks for reporting @nimuxoha and thanks for the diagnostic @kellnerd!

I already had to use this trick for the same problem #600 too. Without your comment I would have probably wasted time understanding before finding this cause back. 😁👍

jesus2099 commented 1 year ago

I should also make a shared function like you, as now, this problem affects 2 scripts, and probably more, in the future.

jesus2099 commented 1 year ago

It seems OK now. Please tell if not. :)