jesus2099 / konami-command

power‐ups for various web sites
117 stars 25 forks source link

Digital cover arts sometimes not hidden #788

Open jesus2099 opened 9 months ago

jesus2099 commented 9 months ago

Probably depending on concurrent loading with FUNKEY CAA, digital cover arts are randomly not hidden.

Seen this on Sony Music Labels, where there are no cover arts on physical releases, only on digital releases.

On desktop, no problems: no cover arts, and the hide/show button works. On mobile: they randomly appear, and if so, the hide/show button is ineffective on these cover arts.

My desktop and mobile list of userscripts is almost the same and those script are in the same order (HIDE DL is in the middle and FUNKEY CAA is at the end).

It's random, so it's not because of #644.

jesus2099 commented 9 months ago

Oh same happens in Raspbian 10 with Chrommium.

jesus2099 commented 9 months ago

Ah it's because of this:

https://github.com/jesus2099/konami-command/blob/58add7c9dc5b0d3b3f16eb82f67a10f1d93976bc/mb_HIDE-DIGITAL-RELEASES.user.js#L77

I should make it an interval that stops once found, a wait_for_element() or anything like that.