jesus2099 / konami-command

power‐ups for various web sites
117 stars 25 forks source link

Ampersand is not escaped for GnuDb searches #799

Closed jesus2099 closed 3 months ago

jesus2099 commented 7 months ago

↖ #488 – y-van-z/yvanzo’s All shook up links


GnuDb search at least fails in https://musicbrainz.org/release/05e6a81e-db6d-4dd7-9fc3-2d5a181d481e that contains an ampersand (&).

Strange I found same bug was already fixed in #776!

Maybe it's because one of these reasons:

jesus2099 commented 7 months ago

Ah, it's specific to GnuDb search (#782)!

jesus2099 commented 7 months ago

In fact it's GnuDb itself that does not support &, even with its own search form. I should strip out & from search...

jesus2099 commented 7 months ago

I can either remove & or replace it with full width .

jesus2099 commented 7 months ago

It's apparently a GnuDb regression because it apparently used to work in January: https://gnudb.org/false-accusations-bliss-music.php with as an example https://gnudb.org/album/sweet+%26+heart+6?page=42

But I didn't find how to report the bug.

jesus2099 commented 7 months ago

I notified GnuDb.org webmaster:

There is a problem on the GnuDb.org search form. If our search contains the ampersand character (&), the searched string is cut at its position, althoug the URL seems right:

https://gnudb.org/search.php search for "Bob Marley & The Wailers" https://gnudb.org/search/%22Bob+Marley+&+The+Wailers%22 https://gnudb.org/search/%22Bob+Marley+%26+The+Wailers%22

Result same as just https://gnudb.org/search/%22Bob+Marley+

Manual workarounds:

Fullwidth ampersand: "Bob Marley & The Wailers" https://gnudb.org/artist/%22Bob+Marley+%EF%BC%86+The+Wailers%22

Strip character off: https://gnudb.org/artist/%22Bob+Marley+The+Wailers%22

jesus2099 commented 6 months ago

After exchanges with René Mogensen, now it works! Maybe I should change my ALL LINKS GnuDb.org search to POST, like their new version...