search

jesus2099 / konami-command

power‐ups for various web sites
123 stars 27 forks source link

Can’t add/remove the same release to/from several highlighted collections #822

Closed DoktorSultan closed 3 days ago

DoktorSultan commented 6 months ago

I have a few different collections, but as some overlap, I sometimes add the same release to two different collections.

This is not possible while the collection highlighter script is running. Currently I need to do a workaround: disable the userscript before adding it to a second collection, then enabling the userscript again.

The workaround works fine and causes no issues, but at first I didn't realise it didn't add the release to the second collection until I was missing a release I was sure I added.

jesus2099 commented 5 months ago

@DoktorSultan, can you explain step by step how to reproduce this bug?

I tried this and had no problems, please help:

  1. Add to (highlighted) release collection
  2. Add to another (not highlighted) release collection

It's added to both. Is the problem when adding to 2 highlighted collections?

DoktorSultan commented 5 months ago

Is the problem when adding to 2 highlighted collections?

@jesus2099 Yes, the problem is when adding to 2 highlighted collections.

I just reproduced it again. It delivers the following message: Refreshing memory… Fetching releases… Received 1 release:

 1. [Juju](https://musicbrainz.org/release/8430243b-3f88-443e-bd62-7f7296c4b728)

No new releases.

jesus2099 commented 3 days ago

If I add support for Add to test collection 2 (which I should do),

Then we have a problem when it's in test collection 1 and test collection 2, and I click on Remove from test collection 1:

It will remove release from userscript, although it is still in test collection 2.

jesus2099 commented 3 days ago

Now it works to dynamic update (add and to remove) same release with several highlighted collections! Thanks again for the bug report, @DoktorSultan.