search

jesusaurus / jenkins-logstash-plugin

Jenkins plugin to ship the console log off to Logstash
MIT License
6 stars 135 forks source link

Plugin requires password #1

Open stackedsax opened 11 years ago

stackedsax commented 11 years ago

If I leave a password out, a build will break with the following exception:

Feb 4, 2013 6:27:44 PM hudson.model.Run handleFatalBuildProblem SEVERE: #10 failed to build and we don't even have a listener redis.clients.jedis.exceptions.JedisDataException: ERR invalid password at redis.clients.jedis.Protocol.processError(Protocol.java:54) at redis.clients.jedis.Protocol.process(Protocol.java:61) at redis.clients.jedis.Protocol.read(Protocol.java:122) at redis.clients.jedis.Connection.getStatusCodeReply(Connection.java:152) at redis.clients.jedis.BinaryClient.connect(BinaryClient.java:57) at redis.clients.jedis.Connection.sendCommand(Connection.java:77) at redis.clients.jedis.Connection.sendCommand(Connection.java:73) at redis.clients.jedis.BinaryClient.auth(BinaryClient.java:467) at redis.clients.jedis.Jedis.auth(Jedis.java:1966) at hudson.plugins.logstash.LogstashBuildWrapper$LogstashOutputStream.<init>(LogstashBuildWrapper.java:160) at hudson.plugins.logstash.LogstashBuildWrapper$LogstashOutputStream.<init>(LogstashBuildWrapper.java:136) at hudson.plugins.logstash.LogstashBuildWrapper.decorateLogger(LogstashBuildWrapper.java:121) at hudson.model.Run.execute(Run.java:1544) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46) at hudson.model.ResourceController.execute(ResourceController.java:88) at hudson.model.Executor.run(Executor.java:236) Feb 4, 2013 6:27:44 PM hudson.model.Run handleFatalBuildProblem SEVERE: #10 failed to build and we don't even have a listener java.lang.NullPointerException at hudson.tasks.BuildTrigger.execute(BuildTrigger.java:193) at hudson.model.AbstractBuild$AbstractBuildExecution.cleanUp(AbstractBuild.java:750) at hudson.model.Build$BuildExecution.cleanUp(Build.java:194) at hudson.model.Run.execute(Run.java:1601) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:46) at hudson.model.ResourceController.execute(ResourceController.java:88) at hudson.model.Executor.run(Executor.java:236)

I can add a password with redis, but the plugin should be able to handle a null password better.

jesusaurus commented 11 years ago

Thanks for catching this, I was only testing against a passworded redis server. This project's upstream has moved over here. Can you go there and confirm that the master branch works for you? If it does, I'll push out a new release.