search

jesusmgg / comic-shanns-mono

a classy font for programming
MIT License
102 stars 6 forks source link

Replace duplicated glyphs with References and Fix carons #7

Closed Rodrigodd closed 1 month ago

Rodrigodd commented 6 months ago

I was looking today into adding accents to ampersand's Comic Sans, but I thankfully found out about this fork before committing any work to it.

But while examining this font and comparing it to the original Comic Sans, I noticed that many of the accented glyphs could benefit from references (as Comic Sans does) instead of copying the vector data (as it currently does). To fix this, I just had to run "Edit -> Replace with Reference" in FontForge on all glyphs, and it fixed it automatically. I didn't extensively revised everything, but I didn't find any error caused by it or obviously missed opportunities.

I have zero experience in font editing, so I am not sure if there are any drawbacks to it, but it already decreased the size of the TTF font by 56% (the OTF stayed the same size), and it should help with maintainability.

I also included a script for generating the fonts from source that I made while figuring out how to build the font. But I can remove it if you think it is not necessary.

I didn't update the font files because I don't know if you prefer to update them only at version releases to avoid increasing the repository size.

Finii commented 4 months ago

This is really a great improvement. It made it possible for me to fix all the wrong carons in no time :rocket:

See also

which is a PR against this PR :grimacing:

Related:

jesusmgg commented 4 months ago

This looks great. Can you include instructions about the build script in the README? (Just a "this is an option to build the font").

Once @Finii PR is merged into this one we can merge everything into master.

Rodrigodd commented 4 months ago

@jesusmgg all done.

Notice that the build of the new version of the font was not committed in this PR. If you want me to include it already built, let me know.

Rodrigodd commented 2 months ago

@jesusmgg Been a while since this PR was ready. Is there anything else that needs to be done before merging this?

Finii commented 1 month ago

Thank you @jesusmgg :+1: