search

jesuspc / node_club-dictionaries

A dictionaries microservices for Workshare's Node club
1 stars 0 forks source link

implemented create #13

Closed JamesSwandale closed 8 years ago

JamesSwandale commented 8 years ago

There are probably more elegant solutions to this, please give it a review and let me know any areas I can improve.

jesuspc commented 8 years ago

Good work again! There are just some minor issues under my point of view.

Btw, probably we should start unit testing stuff too

JamesSwandale commented 8 years ago

Thanks for the comments, I've fixed the issues, I wasn't sure what to do with "move that logic into a parameterizer" currently I've moved it into a function to deal with later.