search

jesusprubio / up

📶 Troubleshoot problems with your Internet connection
MIT License
446 stars 20 forks source link

feat: Add custom dns resolver #54

Closed mohitsethia closed 1 month ago

mohitsethia commented 4 months ago

Adding the support of the custom DNS Resolver, reads with -r flag & would use the default one if not provided. issue [link]

hugoh commented 3 months ago

@mohitsethia - thanks for implementing this.

The current implementation of the DNS probe seemed a bit backward to me: it resolves a name using the local DNS server. While it may be a good indication if whether the local computer's connection is up, it's not necessarily a great indicator of whether the internet connection is for a site as the response may be cached. It would be more interesting to resolve a host with an external DNS server, which you've implemented.

I make use of up in a tool of mine and have bumped into this issue: see hugoh/upd#26.