search

jesusrp98 / expand_widget

Ability to easily expand and retract a widget collection or text
https://pub.dev/packages/expand_widget
GNU General Public License v3.0
45 stars 22 forks source link

Add horizontal support #25

Closed samu-developments closed 3 years ago

samu-developments commented 3 years ago

Thanks for this package! I needed horizontal support, this is a quick implementation of that.

jesusrp98 commented 3 years ago

Thanks for the feature implementation @oyvindsam ! And sorry it took so long for me to check out. I'll take a look at the code now, would you be able to post some examples of how this feature works?

Been trying to check its behaviour with no success :/

samu-developments commented 3 years ago

Thanks for the feature implementation @oyvindsam ! And sorry it took so long for me to check out. I'll take a look at the code now, would you be able to post some examples of how this feature works?

Been trying to check its behaviour with no success :/

Sure thing, added an example!

jesusrp98 commented 3 years ago

OK I see what you've done now. I've encountered a failure here in the example app.

image

Basically it overexands. We need to fix this, maybe wrapping the child inside an exanded widget? Let me know if you need help here

samu-developments commented 3 years ago

Hm yes I did not account for that, I updated the example with how I implemented it in my other app. I am not sure how it would be done if expand_widget were to handle it itself.

jesusrp98 commented 3 years ago

Hey @oyvindsam . I've updated the expansion API. Now it's using the Axis enum variable (horizontal or vertical) and it's vertical by default.

Check it out and I'll merge it to master!

Also, regarding the fix to the example, I think that could work. The ExpandChild widget shouldn't not include the SingleChildScrollView widget inside, it should be an external solution to it.

Massive thanks for supporting this package!!

samu-developments commented 3 years ago

Cool, looks good!