Red screen of death - Githubissues

jesusrp98 / spacex-go

Simple yet powerful, open-source SpaceX launch tracker.

https://play.google.com/store/apps/details?id=com.chechu.cherry

GNU General Public License v3.0

877 stars 252 forks source link

Red screen of death #132

Closed bahaafathi closed 3 years ago

bahaafathi commented 3 years ago

i hope to assigned this bug to me and accept my pull request to this great beautiful app, Thanks.

jesusrp98 commented 3 years ago

Hey @bahaafathi! Thank you very much for the support and for taking the time to find bugs!

I've read the fix you've done in your PR, but I don't think it's optimal, because displaying empty data on the 'Payload' card would be weird.

Instead, what I think should be done is to open an Issue on the r/SpaceX API GitHub page, for the maintainer to notice that there's a future launch, with no payload attached to it.

What do you think about it?

bahaafathi commented 3 years ago

You're right displaying empty data is weird. but less weird than the red page and it's a temporary solution, I've open an Issue on the SpaceX API to solve this problem,

bahaafathi commented 3 years ago

problem solved by SpaceX API

jesusrp98 commented 3 years ago

Nice! Thank you very much for noticing this! Closing the issue.