search

jesusrp98 / spacex-go

Simple yet powerful, open-source SpaceX launch tracker.
https://play.google.com/store/apps/details?id=com.chechu.cherry
GNU General Public License v3.0
880 stars 252 forks source link

Contrast in SearchBar/TopBar in light theme #35

Closed deandreamatias closed 5 years ago

deandreamatias commented 5 years ago

Environment

SpaceX Go Version: 2.4.0 - better-ux Android Version: 8.0 Device Information:

Description

Expected behavior: When using the search function, in the search field, have a contrast between the word 'search' and the field. Current behavior: Don't have a contrast.

Steps to reproduce

  1. Go to settings.
  2. Select the light theme
  3. Return to Home
  4. Select the Vehicle, Upcoming or Lastest Tab.
  5. Press Search FAB
  6. Look the contrast

Images: photo5032814206570833972

jesusrp98 commented 5 years ago

Since I'm using the material_search package, and it doesn't allow to change the textbox's color, I can't do anything to fix this issue.

Fortunately, I've been planning to update the search screen for a while now. I'm planning to add more filter options, and of course, fix this issue as well.

This new search screen is planned for the June-July update.

jesusrp98 commented 5 years ago

Finally, I have the time to take a look at this issue.

I'm building a new component, extending the SeachDelegate class from the Flutter framework, which will allow me to implement a more customized search experience.

One thing I wanted to add is new filtering options. At first, I wanted to add another screen where the user would be allow to select launch year & vehicle etc, but then I thought that building this functionality into the search bar itself may be a better idea. So now the user will be able to write 2019 or Falcon Heavy in the text field itself.

Building this new search experience will allow me to fix this issue itself as well :)

This feature is being develop in the search branch, and should be available to all users in the v2.7 update, hopefully launching this next month.

jesusrp98 commented 5 years ago

After some months of work, this feature is now implemented in the v2.7 update!

You can now filter by mission name or launch vehicle, and on the vehicle side by name or maiden launch year.

The UI now tells the user these new filter options. Contrast bugs have also been fixed, since I'm now using the SearchDelegate method from the Flutter framework.