Latest tab crash on refresh and scroll down without internet

mneira10 commented 5 years ago

Environment

App version:

2.3.1

Android version:

Android 9 - API 28

Device information:

Xiaomi Mi 8 Lite

Description

Current behaviour: When there is no data (or the user turns off wifi and mobile data), refreshes the latest tab and scrolls down, the app displays a red screen with a range error.

Related to #10

Expected behaviour:

The app should not display errors if there is no data and the latest page is refreshed.

Steps to reproduce

Start app
Navigate to latest
Turn off all data - wifi and mobile data
Reload page
Scroll down

Video

jesusrp98 commented 5 years ago

Planning to add connection awareness, for both loading & reloading methods in the near future. What you've implemented in the pull request is a pretty good start.

Like the image quality settings, this will be implemented in the v2.5 update. You can continue tinkering with this feature in #38 if you want to :)

Thank you very much!

jesusrp98 commented 5 years ago

Connection awareness

jesusrp98 commented 5 years ago

Changes made to control network status are now pulled to the dev branch.

Every time the user pulls to refresh the screen, it checks if there's internet available. If not, information will be kept at display, and then warns the user that there isn't an internet connection available to download data from.
Also, if the app starts and it checks that there's no internet, it will show a custom screen, like this one.

This function inside the QueryModel is the one responsible for checking internet connection.

  // Checks internet connection & sets [_status] variable
  Future<bool> connectionFailure() async {
    _status =
        await Connectivity().checkConnectivity() == ConnectivityResult.none
            ? Status.error
            : Status.loading;
    return !isLoading;
  }

Once again, thanks for taking the time to help in the development of this app :)

jesusrp98 / spacex-go