search

jesusrp98 / spacex-go

Simple yet powerful, open-source SpaceX launch tracker.
https://play.google.com/store/apps/details?id=com.chechu.cherry
GNU General Public License v3.0
880 stars 252 forks source link

fix for jesusrp98/spacex-go/issues/7 #8

Closed bkbonner closed 5 years ago

bkbonner commented 5 years ago

This fixes issue 7

jesusrp98 commented 5 years ago

It seems that on Android, if OK if you try to add an event without a description. I didn't know it was an issue on iOS. Also, I don't currently own any iOS device, so it was impossible for me to test with feature more extensively on other platforms outside Android.

I've tweaked once more the 'Add event' feature. Now, if a launch doesn't have a description, it will simply add 'This mission has currently no details' as description.

Thank you very much :)

bkbonner commented 5 years ago

Understood. I ran it on the iOS simulator, which unfortunately requires a mac. Thanks for making the app.

On Thu, Jan 31, 2019 at 9:01 AM Chechu notifications@github.com wrote:

It seems that on Android, if OK if you try to add an event without a description. I didn't know it was an issue on iOS. Also, I don't currently own any iOS device, so it was impossible for me to test with feature more extensively on other platforms outside Android.

I've tweaked once more the 'Add event' feature. Now, if a launch doesn't have a description, it will simply add 'This mission has currently no details' as description.

Thank you very much :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jesusrp98/spacex-go/pull/8#issuecomment-459354353, or mute the thread https://github.com/notifications/unsubscribe-auth/AAowecE0FI7p1fLucovM6eioOeMdC27pks5vIvcfgaJpZM4abiA- .