search

jet / FsCodec

F# Event-Union Contract Encoding with versioning tolerant converters supporting System.Text.Json and Newtonsoft.Json
https://github.com/jet/dotnet-templates
Apache License 2.0
83 stars 19 forks source link

Remove Some null handling wart #39

Closed bartelink closed 4 years ago

bartelink commented 4 years ago

Some null renders as null atm; as evidenced by the diffs, removing that wart makes for less special cases in tests re #38

bartelink commented 4 years ago

@ylibrach any insights much appreciated ;)

bartelink commented 4 years ago

Hm; conditional serialization is not a thing in System.Text.Json v 4.7; there's no reasonable way to implement such a special case Also, going down the rathole has removed any desire I have to special case it - I've simply noted that Some null is not a roundtrippable value.