Closed bartelink closed 2 years ago
This has a set of failing test cases that need to be fixed.
The impl should end up being low double digit lines of code, but parking for someone with the time to do some reading of STJ source and/or fiddling about to handle the more complex cases cleanly!
Woohoo I found the problem/solution (some tidying and/or extending of test suite still to be done, but seems this is on track for finally being released) cc @NickDarvey
The bulk of the commits in this PR derive from https://github.com/jet/FsCodec/pull/43 by @nickdarvey
In particular, the entire implementation and test suite was already complete, but was parked (and inadvertently closed, hence its in this PR).
The later commits effect minor cleanups:
#ifdef
s to make clear the commonalities (and, most importantly, the minor differences) between theSystem.Text.Json
andNewtonsoft.Json
implementations wrt Pickling and JsonIsomorphismUnionConverterTests
to test the STJ and JNK variants with a common test suite