search

jet / FsKafka

Minimal F# wrappers for Confluent.Kafka+librdkafka.redist 1.x
https://github.com/jet/dotnet-templates
Apache License 2.0
88 stars 17 forks source link

Change licence to Apache #1

Closed vchekan closed 6 years ago

vchekan commented 6 years ago

It is recommended by Paket to submit bootstrap and not paket.exe: https://fsprojects.github.io/Paket/faq.html#What-files-should-I-commit

First, bootstrap is 63Kb vs 8Mb of paket. Second, bootstrap is rarely changed whereas paket.exe is regularly updated.

The way it works, is if there is no paket.exe, then bootstrap is run to download paket: https://github.com/jet/confluent-kafka-fsharp/blob/b1f32729d801ab66b35673411716fd552a95ad83/.paket/paket.targets#L31 There is no magic mode involved in the way .paket/paket.targets works.

From the documentation:

The following files should not be committed to your version control system, and should be added to any ignore files:

.paket/paket.exe, the main Paket executable, downloaded by .paket/paket.bootstrapper.exe. It should not be committed, as it is a binary file which can unnecessarily bloat repositories, and because it is likely to be updated on a regular basis.

eiriktsarpalis commented 6 years ago

@vchekan I'm referring to this function https://fsprojects.github.io/Paket/bootstrapper.html#Magic-mode