search

jet / FsKafka

Minimal F# wrappers for Confluent.Kafka+librdkafka.redist 1.x
https://github.com/jet/dotnet-templates
Apache License 2.0
88 stars 17 forks source link

Fix eager offset storage bug #10

Closed chrnola closed 6 years ago

chrnola commented 6 years ago

Await handle before storing new offsets

If we don't do this then we run the risk of committing offsets for messages that may not have been handled yet. It exposes consumers to the possibility of consuming messages more than once, but makes this wrapper behave closer to how Kafunk does in terms of at-least-once semantics.

Addresses one of the concerns raised in #9.

vchekan commented 6 years ago

Doh, nice catch. My test environment behaves funky, as soon as I fix it, I'll merge.