Closed vchekan closed 6 years ago
Agree. (I use Serilog without any concrete logger to good effect (IMO) in Foldunk though, so would not be against a dependency on that). Happy to discuss pros/cons
Rationale for hardcoding NLog was to faithfully emulate kafunk behaviour. A proper logger agnostic library should expose observables like the underlying CK library does.
How about calling existing [Consumer|Producer].OnLog? If application has been attached to this event, it will log with app-specific logger without wrapper being bound to the logger.
Dropped NLog, onLog event is exposed and it is up to the app now, how to do logging.
Description
CK does not have logger dependency. It has OnLog callback leaving it to the application to do wiring to concrete logger implementation. By introducing NLog dependency we may inconvenience people who use other loggers, log4net for example.